[Monitor Ingestion] Regenerate from Typespec#46166
Open
pvaneck wants to merge 2 commits intoAzure:mainfrom
Open
[Monitor Ingestion] Regenerate from Typespec#46166pvaneck wants to merge 2 commits intoAzure:mainfrom
pvaneck wants to merge 2 commits intoAzure:mainfrom
Conversation
Updated tsp-location.yaml to new specs repo path. Regeneration introduces updates and improvements to generated code. - Moves the project to pyproject.toml based - Fixes pyright failures in CI Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Regenerates azure-monitor-ingestion from the updated TypeSpec source location, modernizing the package layout (pyproject-based) and incorporating generator-driven updates intended to address CI type-checking issues.
Changes:
- Updated
tsp-location.yamlto point at the newazure-rest-api-specspath/commit for Monitor Ingestion. - Migrated packaging metadata from
setup.pytopyproject.toml(removingsetup.py). - Regenerated client/operations/utils code (typing updates, serialization/model-base updates, and metadata tweaks).
Reviewed changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| sdk/monitor/azure-monitor-ingestion/tsp-location.yaml | Updates TypeSpec directory/commit pointer for regeneration source. |
| sdk/monitor/azure-monitor-ingestion/setup.py | Removed legacy setuptools build script in favor of pyproject.toml. |
| sdk/monitor/azure-monitor-ingestion/pyproject.toml | New build/project metadata and dependencies for pyproject-based packaging. |
| sdk/monitor/azure-monitor-ingestion/azure/monitor/ingestion/aio/_operations/_patch.py | Aligns patched async ops mixin naming with regenerated code. |
| sdk/monitor/azure-monitor-ingestion/azure/monitor/ingestion/aio/_operations/_operations.py | Regenerated async operations mixin + updated typing. |
| sdk/monitor/azure-monitor-ingestion/azure/monitor/ingestion/aio/_operations/init.py | Updates async operations exports/patch wiring. |
| sdk/monitor/azure-monitor-ingestion/azure/monitor/ingestion/aio/_configuration.py | Docstring updates for API version wording. |
| sdk/monitor/azure-monitor-ingestion/azure/monitor/ingestion/aio/_client.py | Updates async client base mixin reference. |
| sdk/monitor/azure-monitor-ingestion/azure/monitor/ingestion/_utils/serialization.py | Typing modernizations and safer basic-type conversions. |
| sdk/monitor/azure-monitor-ingestion/azure/monitor/ingestion/_utils/model_base.py | Significant changes to (de)serialization helpers and rest field behavior. |
| sdk/monitor/azure-monitor-ingestion/azure/monitor/ingestion/_operations/_patch.py | Aligns patched sync ops mixin naming with regenerated code. |
| sdk/monitor/azure-monitor-ingestion/azure/monitor/ingestion/_operations/_operations.py | Regenerated sync operations mixin + updated typing/request building. |
| sdk/monitor/azure-monitor-ingestion/azure/monitor/ingestion/_operations/init.py | Updates sync operations exports/patch wiring. |
| sdk/monitor/azure-monitor-ingestion/azure/monitor/ingestion/_configuration.py | Docstring updates for API version wording. |
| sdk/monitor/azure-monitor-ingestion/azure/monitor/ingestion/_client.py | Updates sync client base mixin reference. |
| sdk/monitor/azure-monitor-ingestion/_metadata.json | Adds apiVersions mapping alongside apiVersion. |
sdk/monitor/azure-monitor-ingestion/azure/monitor/ingestion/_utils/model_base.py
Show resolved
Hide resolved
pvaneck
requested review from
Haiying-MSFT,
KarishmaGhiya,
KevinBlasko,
ToddKingMSFT,
joshfree,
scottaddie and
srnagar
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated tsp-location.yaml to new specs repo path.
Regeneration introduces updates and improvements to generated code.